Skip to content

13 setup benchviper to create tests for astroviper#15

Merged
smcastro merged 12 commits intomainfrom
13-setup-benchviper-to-create-tests-for-astroviper
Mar 25, 2026
Merged

13 setup benchviper to create tests for astroviper#15
smcastro merged 12 commits intomainfrom
13-setup-benchviper-to-create-tests-for-astroviper

Conversation

@awells-nrao
Copy link
Copy Markdown
Contributor

No description provided.

@awells-nrao awells-nrao linked an issue Mar 20, 2026 that may be closed by this pull request
@awells-nrao awells-nrao requested a review from smcastro March 20, 2026 17:43
@awells-nrao awells-nrao self-assigned this Mar 20, 2026
# benchviper organizes each external project in its own subdir
cd astroviper
asv machine --machine gh-runner --yes
asv run "--merges v0.0.30..main" --machine gh-runner --parallel --interleave-rounds --skip-existing
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check if 0.0.30 is the correct starting version

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave it at 0.0.30 for now as I don't know either which would be the best version. It will probably depend on which tests we will write first. I need to talk to the dev team about this.

Comment thread astroviper/benchmarks/benchme.py Outdated
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample File to store as a placeholder until other tests are written

Comment thread astroviper/asv.conf.json
// Customizable commands for installing and uninstalling the project.
// See asv.conf.json documentation.
//"install_command": ["in-dir={env_dir} python -m pip install {build_dir}/dist/*.whl"],
"install_command": ["in-dir={env_dir} python -m pip install {wheel_file}[all]"],
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check If installing all is correct option

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the correct option.

Comment thread astroviper/asv.conf.json Outdated
"build_command": [
"python -m pip install build",
"python -m build --wheel",
"python -m pip install scikit_build_core pybind11",
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scikit_build_core and pybind11 need to be installed as prerequisites before building from pyproject toml, so this line possible can be moved to a more appropriate place

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need these lines:
`python -m pip install build",
"python -m build --wheel",
"python -m pip wheel --no-deps -w {build_cache_dir} {build_dir}"

Comment thread astroviper/benchmarks/benchme.py Outdated
Benchmark that times various operations, including custom summation of
lists.
"""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not important for this mock example, but it is important for the real benchmark tests. We need to add a line giving the version of the tests, basically matching the 0.0.30 of the asv run command. This is so that the tests do not use a unique hash for every run. This will allow us to update the tests if we need due to expected changes to the astroviper code. The line to add is:
version = "astroviper 0.0.30"

Comment thread astroviper/asv.conf.json Outdated
"build_command": [
"python -m pip install build",
"python -m build --wheel",
"python -m pip install scikit_build_core pybind11",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only need these lines:
`python -m pip install build",
"python -m build --wheel",
"python -m pip wheel --no-deps -w {build_cache_dir} {build_dir}"

@smcastro smcastro merged commit 893a55a into main Mar 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup benchviper to create tests for astroviper

2 participants