v0.0.2, add cookie mode #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodece @GopherJ please review. |
|
@kingiw please fix DCO. |
hsluoyz
requested changes
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
example/react/src/CasbinDemo.js
Outdated
| return ( | ||
| <div> | ||
| <p>====</p> | ||
| { this.auth.can('read', 'alice_data') && alice_div } |
There was a problem hiding this comment.
alice_div is component, should be use <AliceDiv>.
There was a problem hiding this comment.
Nope, AliceDiv is a JSX Element and it should used like this.
nodece
reviewed
Jul 25, 2020
nodece
reviewed
Jul 25, 2020
kingiw
force-pushed
the
master
branch
2 times, most recently
from
3677fa2 to
43695d5
Compare
Signed-off-by: kingiw <kingiw@hotmail.com>
Signed-off-by: kingiw <kingiw@hotmail.com>
Signed-off-by: kingiw <kingiw@hotmail.com>
Signed-off-by: kingiw <kingiw@hotmail.com>
|
I've removed the example files from the PR |
nodece
approved these changes
Jul 27, 2020
Please replace existing commits. The example should not show up in commits. |
|
@kingiw You should update the PR title. |
hsluoyz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.