Skip to content

fix: return empty list when name does not exist in getRoles function.#166

Merged
hsluoyz merged 1 commit intocasbin:masterfrom
shy1st:master
Mar 12, 2021
Merged

fix: return empty list when name does not exist in getRoles function.#166
hsluoyz merged 1 commit intocasbin:masterfrom
shy1st:master

Conversation

@shy1st
Copy link
Contributor

@shy1st shy1st commented Mar 12, 2021

fix: #162

@shy1st shy1st requested a review from hsluoyz March 12, 2021 07:18
@codecov-io
Copy link

Codecov Report

Merging #166 (42da984) into master (ff7a62e) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
- Coverage   65.43%   65.36%   -0.07%     
==========================================
  Files          37       37              
  Lines        2022     2021       -1     
  Branches      354      354              
==========================================
- Hits         1323     1321       -2     
- Misses        594      597       +3     
+ Partials      105      103       -2     
Impacted Files Coverage Δ
...va/org/casbin/jcasbin/rbac/DefaultRoleManager.java 80.45% <100.00%> (+0.22%) ⬆️
...rc/main/java/org/casbin/jcasbin/main/Enforcer.java 85.71% <0.00%> (-3.81%) ⬇️
src/main/java/org/casbin/jcasbin/model/Model.java 72.50% <0.00%> (-0.68%) ⬇️
src/main/java/org/casbin/jcasbin/util/Util.java 66.19% <0.00%> (+4.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7a62e...42da984. Read the comment docs.

@hsluoyz hsluoyz merged commit bc12d05 into casbin:master Mar 12, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Mar 12, 2021

🎉 This PR is included in version 1.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

getImplicitRolesForUser fails if user has no explicitly assigned roles

4 participants