perf: remove redundant reinitialization of policyMap#137
Merged
hsluoyz merged 1 commit intoapache:masterfrom May 13, 2022
Merged
perf: remove redundant reinitialization of policyMap#137hsluoyz merged 1 commit intoapache:masterfrom
hsluoyz merged 1 commit intoapache:masterfrom
Conversation
|
|
|
@Edmond-J-A please review |
|
@Edmond-J-A please review |
Member
|
🎉 This PR is included in version 1.41.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reference with #136.
The
policyMapis being reinitialized entirely from thepolicyat every line load, instead we can set the mapping for every line as it is being loaded.Running a benchmark script to load a medium sized model (1k policies and 10k grouping policies) from file: