fix: improve performance by removing non-essential but resource-intensive logging#140
Merged
hsluoyz merged 2 commits intoapache:masterfrom Jan 12, 2023
Merged
fix: improve performance by removing non-essential but resource-intensive logging#140hsluoyz merged 2 commits intoapache:masterfrom
hsluoyz merged 2 commits intoapache:masterfrom
Conversation
|
@Edmond-J-A @rushitote please review |
|
|
hsluoyz
changed the title
|
🎉 This PR is included in version 1.41.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix part of #136
Thank you very much for a previous pr for performance optimization.
However, in actual use, it is found that when the policy exceeds 20k lines, it still takes about 4 seconds for the API to load for the first time.
After digging deeper, I found out that it was because of
o.model:printPolicy()after load policy, so I removed it. I think we already has a detailed log when enforce, and there is no need to save all policy content in the log, what do you think?