Skip to content

Conversation

@lexnow
Copy link
Member

@lexnow lexnow commented Aug 10, 2018

refactor FileAdapter and Enforcer with async/await

@hsluoyz
Copy link
Member

hsluoyz commented Aug 10, 2018

Why the Travis CI failed?

@lexnow
Copy link
Member Author

lexnow commented Aug 10, 2018

@hsluoyz Because the async/await must support by node lowest version 8.5.6

@hsluoyz
Copy link
Member

hsluoyz commented Aug 11, 2018

But Node v10.8.0 also failed, see here: https://travis-ci.org/casbin/node-casbin/jobs/414532550

@coveralls
Copy link

Pull Request Test Coverage Report for Build 31

  • 16 of 67 (23.88%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 48.003%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/util/util.ts 8 14 57.14%
src/persist/fileAdapter.ts 4 10 40.0%
src/persist/defaultFilteredAdapter.ts 1 8 12.5%
src/enforcer.ts 3 35 8.57%
Files with Coverage Reduction New Missed Lines %
src/enforcer.ts 2 34.01%
Totals Coverage Status
Change from base Build 28: -0.4%
Covered Lines: 436
Relevant Lines: 836

💛 - Coveralls

@hsluoyz hsluoyz merged commit ac5fdc5 into casbin:master Aug 11, 2018
nodece pushed a commit to nodece/node-casbin that referenced this pull request Mar 27, 2023
Signed-off-by: Shivansh-yadav13 <yadavshivansh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants