fix: polish import grammar and remove some useless package #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Nekotoxin please review |
Member
|
@Undertone0809 fix all checks:
|
Contributor
Author
|
@hsluoyz build problem has been solved. I want to know why single blank line cannot pass the build? About Coveralls, maybe I need to study more and new PR to write unit test to improve coverage. |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
## [1.17.5](v1.17.4...v1.17.5) (2022-12-05) ### Bug Fixes * polish import grammar and remove some useless package ([#282](#282)) ([be53e0b](be53e0b))
|
🎉 This PR is included in version 1.17.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Chimou0
pushed a commit
to Chimou0/pycasbin
that referenced
this pull request
Jul 17, 2025
* fix: polish import grammar and remove some useless package * fix: remove a blank line
Chimou0
pushed a commit
to Chimou0/pycasbin
that referenced
this pull request
Jul 17, 2025
## [1.17.5](casbin/pycasbin@v1.17.4...v1.17.5) (2022-12-05) ### Bug Fixes * polish import grammar and remove some useless package ([casbin#282](casbin#282)) ([be53e0b](casbin@be53e0b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: https://google.github.io/styleguide/pyguide.html