Skip to content

feat: fix enforce_ex() API returning empty explanations for allow rules in deny models #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 6, 2025
Merged

feat: fix enforce_ex() API returning empty explanations for allow rules in deny models #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5674ab3
Initial plan
Copilot Nov 6, 2025
14c1a9f
Fix enforce_ex to return explanations for allow rules in deny models
Copilot Nov 6, 2025
4531cf3
Improve comment clarity for explain_index update
Copilot Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion casbin/core_enforcer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,8 +481,11 @@ def enforce_ex(self, *rvals):
else:
policy_effects.add(Effector.ALLOW)

# Update explain_index for any matching policy before checking early break condition
# to ensure explanations are captured for allow rules in deny models
explain_index = i

if self.eft.intermediate_effect(policy_effects) != Effector.INDETERMINATE:
explain_index = i
break

else:
Expand Down
9 changes: 9 additions & 0 deletions tests/test_enforcer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,15 @@ def test_enforce_rbac_with_deny(self):
self.assertTrue(e.enforce("alice", "data2", "read"))
self.assertFalse(e.enforce("alice", "data2", "write"))

def test_enforce_ex_rbac_with_deny(self):
e = self.get_enforcer(
get_examples("rbac_with_deny_model.conf"),
get_examples("rbac_with_deny_policy.csv"),
)
# Test that enforce_ex returns explanations for both allow and deny cases
self.assertTupleEqual(e.enforce_ex("alice", "data2", "read"), (True, ["data2_admin", "data2", "read", "allow"]))
self.assertTupleEqual(e.enforce_ex("alice", "data2", "write"), (False, ["alice", "data2", "write", "deny"]))

def test_enforce_rbac_with_domains(self):
e = self.get_enforcer(
get_examples("rbac_with_domains_model.conf"),
Expand Down