feat: fix enforce_ex() API returning empty explanations for allow rules in deny models #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enforce_exreturns empty explanation arrays for allow decisions when using models with explicit deny rules (e.g.,rbac_with_deny_model).Changes
core_enforcer.py: Update
explain_indexfor every matching policy, not just when intermediate effect triggers early break.AllowAndDenyEffector.intermediate_effect()returnsINDETERMINATEfor allow-only cases (must scan all policies for deny), preventingexplain_indexfrom being set.test_enforcer.py: Add
test_enforce_ex_rbac_with_denyto verify explanations are returned for both allow and deny cases.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.