Conversation
…cture BREAKING CHANGES: - Remove `ExecuteAndConfirmResult` type (use `ExecuteResult` instead) - Rename `seed` parameter to `uniqueId` in `estimateSplitRent()` - Flatten module structure: imports now from root, not `/solana` subpath API Design (ADR-0003 compliance): - All functions use flat object parameters - All result types use lowercase `status` discriminant - `splitConfig` is primary identifier (not `vault`) - Token program auto-detection enabled by default - ATA auto-creation enabled by default with opt-out Module Structure Changes: - Move all source from `src/solana/` to `src/` - Move `src/solana/client/` to `src/client/` - Move `src/solana/generated/` to `src/generated/` - Move `src/solana/web3-compat/` to `src/web3-compat/` - Update all import paths accordingly Code Simplifications: - Remove redundant `as Address` and `as Signature` type assertions - Replace `Parameters<typeof fn>[N]` with inline object spreads - Simplify conditional object building with spread syntax - Use `getSplitConfig` instead of deprecated `getSplitConfigFromVault` Documentation Updates: - Fix ARCHITECTURE.md import paths (remove `/solana` prefix) - Update ADR-0003 status to "Implemented" All 128 tests pass. Type-check and lint clean.
Deploying splits with
|
| Latest commit: |
680d871
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a235e6e.splits-2l5.pages.dev |
| Branch Preview URL: | https://feat-implement-solana-splits.splits-2l5.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements ADR-0003 API design patterns and flattens the SDK module structure for simpler imports.
Breaking Changes
/solanasubpathExecuteAndConfirmResulttype: UseExecuteResultinsteadseed→uniqueIdinestimateSplitRent()ADR-0003 Implementation
statusdiscriminantsplitConfigis primary identifier (notvault)Code Quality
getSplitConfiginstead of deprecatedgetSplitConfigFromVaultTest plan