Add custom error types for catchable ORM failures#359
Merged
rsslldnphy merged 1 commit intomainfrom May 3, 2026
Merged
Conversation
Introduces an OrmError base class plus NotFoundError, TooManyRowsError, and CreateFailedError so consumers can distinguish runtime row-count failures from generic errors via instanceof. Each carries the modelName and operation that caused it; TooManyRowsError also exposes rowCount. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrmErrorbase class so consumers can catch any ORM-thrown error withinstanceof.NotFoundError(single-row op found 0 rows),TooManyRowsError(single-row op found >1), andCreateFailedError(createOnegot 0 rows back) — all extendOrmError.modelNameandoperation;TooManyRowsErroralso exposesrowCount.throw new Error(...)calls infindOne,updateOne,deleteOne, andcreateOnewith the new typed errors. Messages are preserved, so existingrejects.toThrow("...")assertions still match.throw new Errorsites (schema lookups, missing where clauses, connection-state checks, operator validation) were left as plainError— they're programmer errors, not runtime conditions worth catching.Test plan
pnpm typecheckcleanfindOne,updateOne,deleteOne,createOne,middleware.where,findOne.select,findOne.where,findOne.includeManyToOne)