Skip to content

Fix prefix in bookmarkPath; type-review BrowserBookmarkFacet #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajnelson-nist merged 3 commits into from
Oct 2, 2024
Merged

Fix prefix in bookmarkPath; type-review BrowserBookmarkFacet #79

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd6840a
Fix prefix in bookmarkPath
ajnelson-nist Oct 2, 2024
54f6032
Fix copy-paste error
ajnelson-nist Oct 2, 2024
2610a79
Review types
ajnelson-nist Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions case_mapping/uco/observable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,14 +660,14 @@ def __init__(
class BrowserBookmarkFacet(Facet):
def __init__(
self,
accessedTime=None,
application_id=None,
bookmarkPath=None,
modifiedTime=None,
createdTime=None,
urlTargeted_id=None,
visitCount=None,
):
accessedTime: Optional[datetime] = None,
application_id: Optional[ObservableObject] = None,
bookmarkPath: Optional[str] = None,
modifiedTime: Optional[datetime] = None,
createdTime: Optional[datetime] = None,
urlTargeted_id: Optional[ObservableObject] = None,
visitCount: Optional[int] = None,
) -> None:
"""
This CASEObject represents a grouping of characteristics unique to a saved shortcut that directs a
WWW (World Wide Web) browser software program to a particular WWW accessible resource.
Expand All @@ -681,7 +681,7 @@ def __init__(
"""
super().__init__()
self["@type"] = "uco-observable:BrowserBookmarkFacet"
self._str_vars(**{"observable:bookmarkPath": bookmarkPath})
self._str_vars(**{"uco-observable:bookmarkPath": bookmarkPath})
self._int_vars(**{"uco-observable:visitCount": visitCount})
self._node_reference_vars(
**{
Expand All @@ -691,7 +691,7 @@ def __init__(
)
self._datetime_vars(
**{
"uco-observable:observableCreatedTime": accessedTime,
"uco-observable:observableCreatedTime": createdTime,
"uco-observable:modifiedTime": modifiedTime,
"uco-observable:accessedTime": accessedTime,
}
Expand Down