Fixed incorrect gravatar url#37
Merged
caseyscarborough merged 1 commit intocaseyscarborough:masterfrom Jun 18, 2021
stopspazzing:master
Merged
Fixed incorrect gravatar url#37caseyscarborough merged 1 commit intocaseyscarborough:masterfrom stopspazzing:master
caseyscarborough merged 1 commit intocaseyscarborough:masterfrom
stopspazzing:master
Conversation
There was an issue before always showing no icons, which it shouldnt even if an email isnt registered with gravatar, will show the default icon. Turns out the old link was invalid, and the code needed to be trimmed(precaution) and lowercased as according to: https://en.gravatar.com/site/implement/hash/
Coding-Hen
approved these changes
Feb 7, 2021
Coding-Hen
left a comment
Coding-Hen
left a comment
There was a problem hiding this comment.
Could we get this merged as the icons are still broken?
caseyscarborough
approved these changes
Jun 18, 2021
Owner
|
Thank you @stopspazzing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue before always showing no icons, which it shouldnt even if an email isnt registered with gravatar, will show the default icon. Turns out the old link was invalid, and the code needed to be trimmed(precaution) and lowercased as according to:
https://en.gravatar.com/site/implement/hash/