Uniform lists only need to calculate item size once#116
Closed
ltgorm wants to merge 1 commit intocaseywebdev:masterfrom
Closed
Uniform lists only need to calculate item size once#116ltgorm wants to merge 1 commit intocaseywebdev:masterfrom
ltgorm wants to merge 1 commit intocaseywebdev:masterfrom
Conversation
Observed that the getItemSizeAndItemsPerRow was at the top of cpu hogs when profiling for traversal of a large list. This change reduces the time spent on getting those attributes
Owner
|
I like the idea, but this is currently a breaking change. At the moment, uniform means all elements are the same size for a given render, but not necessarily the same size for the life of the component. As such, this code would break the case for column sizes that change on window resize or elements that resize responsively. If the performance difference is that significant, it may be worth implementing this behind a new prop ( |
Owner
|
Check out https://github.com/orgsync/react-list/tree/use-static-size for a backwards-compatible option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed that the getItemSizeAndItemsPerRow was at the top of cpu hogs when profiling for traversal of a large list. This change reduces the time spent on getting those attributes.