Conversation
bradfol
force-pushed
the
bradfol/main-actor-tests
branch
2 times, most recently
from
02bf4c8 to
3508b25
Compare
bradfol
force-pushed
the
bradfol/main-actor-tests
branch
from
3508b25 to
3cfa06d
Compare
bradfol
force-pushed
the
bradfol/main-actor-tests
branch
from
3cfa06d to
b3cc5ca
Compare
skorulis-ap
reviewed
Apr 28, 2025
Comment on lines
+172
to
+176
| Task { | ||
| let result = await finalConsumer.askCustomGlobalActorClassToSayHello() | ||
| XCTAssertEqual(result, "Hello") | ||
| asyncExpectation.fulfill() | ||
| } |
Contributor
There was a problem hiding this comment.
Would it be better for the test to be async and await the result without having to create a Task?
skorulis-ap
approved these changes
Apr 28, 2025
skorulis-ap
reviewed
Apr 28, 2025
| ) | ||
|
|
||
| container.register( | ||
| Future<CustomGlobalActorClass, Never>.self, |
Contributor
There was a problem hiding this comment.
You might want to add Future to the list of special naming cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide code use examples of async initializers and test coverage.