Create ContainerManager to prevent needing to directly check for Container registrations#279
Merged
skorulis-ap merged 1 commit intomainfrom May 8, 2025
Merged
Conversation
bradfol
approved these changes
May 7, 2025
Comment on lines
+65
to
+66
| // ContainerManager from the parent of the SwinjectContainer | ||
| private let parent: ContainerManager? |
Contributor
There was a problem hiding this comment.
Alternately we could get this though the swinjectContainer's parent
Contributor
Author
There was a problem hiding this comment.
The Swinject.Container parent is private.
skorulis-ap
force-pushed
the
skorulis/container-manager
branch
from
8052d30 to
d7c19ff
Compare
…ainer registrations
skorulis-ap
force-pushed
the
skorulis/container-manager
branch
from
d7c19ff to
2af9fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to prevent the following errors coming up during testing. The containers get automatically created but since it checks the resolver first an error is raised in the logs which increases noise when looking for real issues.