feat(mint): add issued_time to mint_quotes table#985
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 75.14% 75.24% +0.09%
==========================================
Files 99 99
Lines 11714 11722 +8
==========================================
+ Hits 8803 8820 +17
+ Misses 2911 2902 -9 ☔ View full report in Codecov by Sentry. |
jooray
added a commit
to jooray/nutshell
that referenced
this pull request
May 10, 2026
* upstream/main: fix(models): increase filter max_length to accommodate quote IDs refactor: move hardcoded string max lengths to constants feat(mint): add issued_time to mint_quotes table (cashubtc#985) fix(models): correctly apply Pydantic max_length to strings in lists ci: allow manual docker build trigger (cashubtc#973) fix(docker): replace deprecated --no-dev with --without dev for Poetry 2.x (cashubtc#972) fix(mint): enforce unique x-coordinates in p2pk pubkey deduplication (cashubtc#969)
jooray
added a commit
to jooray/nutshell
that referenced
this pull request
May 10, 2026
* units: fix(models): increase filter max_length to accommodate quote IDs refactor: move hardcoded string max lengths to constants feat(mint): add issued_time to mint_quotes table (cashubtc#985) fix(models): correctly apply Pydantic max_length to strings in lists ci: allow manual docker build trigger (cashubtc#973) fix(docker): replace deprecated --no-dev with --without dev for Poetry 2.x (cashubtc#972) fix(mint): enforce unique x-coordinates in p2pk pubkey deduplication (cashubtc#969) fix(mint): preserve unitsd keyset units and decimals Fix unit inference: use coin_type (index 2) not counter (last segment) from derivation path Update fiat-backend.md for unitsd architecture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #980
Adds
issued_timetomint_quotesin the mint's database to provide a precise timestamp of the most important event for the minting process, which is necessary for failed minting investigations.Modifies:
m033_add_issued_time_to_mint_quoteissued_timetoNut04Quoteinmanagement.proto