#526 Provide better exception message if template engine is initialized with wrong content type#529
Merged
casid merged 8 commits intocasid:mainfrom Mar 17, 2026
Conversation
…ed with ContentType.Plain instead of ContentType.Html and params map is used Follow-up to bafa85d
edward3h
approved these changes
Mar 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
============================================
- Coverage 91.22% 91.17% -0.05%
- Complexity 1221 1222 +1
============================================
Files 76 76
Lines 3178 3183 +5
Branches 490 489 -1
============================================
+ Hits 2899 2902 +3
- Misses 171 173 +2
Partials 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
casid
requested changes
Mar 16, 2026
Owner
casid
left a comment
There was a problem hiding this comment.
Thanks for the PR, can please check my comments?
casid
requested changes
Mar 17, 2026
Owner
casid
left a comment
There was a problem hiding this comment.
Thanks for the investigation! 👍
Just a little clean-up and then this is good to go.
6405b60 to
145a965
Compare
Owner
|
Thanks for your submission @iTob191 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to bafa85d