Merged
Conversation
pull from upstream
Owner
|
Holy shit @edward3h, that looks fantastic! Can't really get much nicer than this! I'll look through the changes this weekend 👍 |
Collaborator
Author
|
The reason there are so many files and changes is because I copied the existing gradle test projects to make the same tests for the new setup. There's probably a way to refactor and reduce duplication, but I'm not planning to work on that now. |
Owner
|
@edward3h yeah, I've seen it. I think duplication is perfectly fine here, maybe one day we can remove the old gradle style tests altogether. |
Owner
|
Merged! Thanks for putting in so much effort in this, this is an incredible improvement of the gradle plugin. That being said, I think it is time for a new release, with native image support and the gradle extension :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the Gradle improvement I was thinking about.
Reduce the amount of boilerplate when using the Gradle plugin by adding an extension with properties and default values.