Skip to content

Gradle plugin improvements#81

Merged
casid merged 7 commits intocasid:masterfrom
edward3h:gradle_defaults
May 7, 2021
Merged

Gradle plugin improvements#81
casid merged 7 commits intocasid:masterfrom
edward3h:gradle_defaults

Conversation

@edward3h
Copy link
Collaborator

@edward3h edward3h commented May 6, 2021

Here's the Gradle improvement I was thinking about.

Reduce the amount of boilerplate when using the Gradle plugin by adding an extension with properties and default values.

@casid
Copy link
Owner

casid commented May 7, 2021

Holy shit @edward3h, that looks fantastic!

jte {
  precompile()
}

Can't really get much nicer than this! I'll look through the changes this weekend 👍

@edward3h
Copy link
Collaborator Author

edward3h commented May 7, 2021

The reason there are so many files and changes is because I copied the existing gradle test projects to make the same tests for the new setup. There's probably a way to refactor and reduce duplication, but I'm not planning to work on that now.

@casid
Copy link
Owner

casid commented May 7, 2021

@edward3h yeah, I've seen it. I think duplication is perfectly fine here, maybe one day we can remove the old gradle style tests altogether.

@casid casid merged commit f82189b into casid:master May 7, 2021
@casid
Copy link
Owner

casid commented May 7, 2021

Merged!

Thanks for putting in so much effort in this, this is an incredible improvement of the gradle plugin.

That being said, I think it is time for a new release, with native image support and the gradle extension :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants