Merged
Conversation
b2d08b0 to
fd4e8f1
Compare
Contributor
Author
|
This PR has a problem. skimage.transform.resize is used for interpolation as follows Lines 445 to 447 in 202eb40 However this does not give "probability maps", and there's no guarantee they'd add to 1 at all. In fact, I get values slightly negative or larger than 1 at edges of the masks (which I don't understand). This seems therefore only correct when using |
Owner
|
Sorry somehow missed the notification about this! Will review and merge in <24h |
Merged
pass the `outres` parameter to ToPetMmr. This meant I had to encode the resolution in the cached filename.
allow returning a 4D array with the masks (useful for PVC for instance)
714868d to
dcaf64d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Act.all_labelsActtrim_zeros_ROI()toPetMmr()returnndarrayThis PR (#8) fixes #2
Also this PR supersedes:
closes fix handling of arguments in get_mmr_fromfile #5 (fixes get_mMR_from_file ignore parameters? #3)already merged