Skip to content

Simplify artifact inspection logic#41

Merged
domust merged 1 commit intomainfrom
simplify-artifact-inspection-logic
Nov 29, 2024
Merged

Simplify artifact inspection logic#41
domust merged 1 commit intomainfrom
simplify-artifact-inspection-logic

Conversation

@domust
Copy link
Copy Markdown
Contributor

@domust domust commented Nov 28, 2024 •
edited
Loading

  • Removed unnecessary functions
  • Added new types and aliases
  • Added comments for old types
  • Updated error handling and logging
  • Calculating digest in advance instead of during layer analysis
  • Open config file only once
  • Properly communicate what artifact info is and how is it related to config
  • Reordered operations to avoid unnecessary error handling (missingImageKey)
  • Split inspect into inspectLayers and inspectImage

@domust domust force-pushed the simplify-artifact-inspection-logic branch 3 times, most recently from f264f2e to 2a795f9 Compare November 28, 2024 12:27
@domust domust force-pushed the simplify-artifact-inspection-logic branch from 2a795f9 to b398bfe Compare November 28, 2024 12:35
@domust domust merged commit 92ad767 into main Nov 29, 2024
@domust domust deleted the simplify-artifact-inspection-logic branch November 29, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@samuelvl samuelvl samuelvl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@domust @samuelvl