Skip to content

Update the timeout #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Update the timeout #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import and configure the library with your Castle API secret.
# For authenticate method you can set failover strategies: allow(default), deny, challenge, throw
configuration.failover_strategy = 'deny'

# Castle::RequestError is raised when timing out in milliseconds (default: 500 milliseconds)
configuration.request_timeout = 1000
# Castle::RequestError is raised when timing out in milliseconds (default: 1000 milliseconds)
configuration.request_timeout = 1500

# Base Castle API url
# configuration.base_url = "https://api.castle.io/v1"
Expand Down
4 changes: 2 additions & 2 deletions castle/configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
# API endpoint
BASE_URL = 'https://api.castle.io/v1'
FAILOVER_STRATEGY = 'allow'
# 500 milliseconds
REQUEST_TIMEOUT = 500
# 1000 milliseconds
REQUEST_TIMEOUT = 1000
# regexp of trusted proxies which is always appended to the trusted proxy list
FAILOVER_STRATEGIES = ['allow', 'deny', 'challenge', 'throw']
TRUSTED_PROXIES = [r"""
Expand Down
2 changes: 1 addition & 1 deletion castle/test/configuration_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def test_default_values(self):
self.assertEqual(config.base_url.path, '/v1')
self.assertEqual(config.allowlisted, [])
self.assertEqual(config.denylisted, [])
self.assertEqual(config.request_timeout, 500)
self.assertEqual(config.request_timeout, 1000)
self.assertEqual(config.failover_strategy, 'allow')
self.assertEqual(config.ip_headers, [])
self.assertEqual(config.trusted_proxies, [])
Expand Down