Merged
Conversation
bartes
force-pushed
the
impersonate
branch
2 times, most recently
from
4c3e430 to
f215f26
Compare
lluft
suggested changes
Jan 26, 2018
| def impersonate(options = {}) | ||
| options = Castle::Utils.deep_symbolize_keys(options || {}) | ||
|
|
||
| return unless tracked? |
Contributor
There was a problem hiding this comment.
remove this. Doesn't apply to impersonate
| private | ||
|
|
||
| def validate!(options) | ||
| %i[user_id].each do |key| |
Contributor
There was a problem hiding this comment.
From impersonate endpoint:
requires :user_id, type: String
requires :user_agent, type: String
requires :ip, type: String
optional :impersonator, type: String
optional :client_id, type: String
Please update validation
Contributor
Author
There was a problem hiding this comment.
@lluft - I'm changing the endpoint . It will look like this before merging this:
requires :user_id, type: String
optional :impersonator, type: String, desc: 'Impersonator email'
optional :context, type: Hash, desc: 'Request context. (includes Ip, User-Agent, ClientId)'
optional :timestamp, desc: 'Timestamp of the event', types: [String, Time]
optional :sent_at, type: String
optional :received_at, type: String
…sending time info for impersonate
Contributor
Author
|
@lluft - added validation for required fields, remove timestamp from that endpoint, now it should be fine |
nijikon
suggested changes
Jan 26, 2018
|
|
||
| before do | ||
| Timecop.freeze(time_now) | ||
| end |
Contributor
There was a problem hiding this comment.
before { Timecop.freeze(time_now) }|
|
||
| after do | ||
| Timecop.return | ||
| end |
Contributor
Author
|
@nijikon - this is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.