Conversation
91a643a to
dca545d
Compare
|
this is a breaking change as far as i can tell. should note it in the changelog + probably should bump major version? |
|
@stevenou support for ruby 2.1 has ended quite while ago: https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/ - not quite sure if it is that much of a breaking change in that case as this ruby versions shouldn't be used at all... |
|
@stevenou And just to add to what @mensfeld wrote, support for |
|
i understand that. i'm arguing this is a breaking change and should be noted as such. though i now see there is huge amounts of debate about whether a dependency change should constitute a major version bump or not. |
No description provided.