Skip to content

require ruby version >= 2.2.6#113

Merged
bartes merged 1 commit intomasterfrom
require-ruby-version-gte-2-2-6
Feb 21, 2018
Merged

require ruby version >= 2.2.6#113
bartes merged 1 commit intomasterfrom
require-ruby-version-gte-2-2-6

Conversation

@nijikon
Copy link
Copy Markdown
Contributor

@nijikon nijikon commented Feb 14, 2018

No description provided.

@nijikon nijikon self-assigned this Feb 14, 2018
@nijikon nijikon force-pushed the require-ruby-version-gte-2-2-6 branch from 91a643a to dca545d Compare February 15, 2018 11:23
@bartes bartes merged commit 7ecdbc4 into master Feb 21, 2018
@bartes bartes deleted the require-ruby-version-gte-2-2-6 branch February 21, 2018 19:31
@stevenou
Copy link
Copy Markdown

this is a breaking change as far as i can tell. should note it in the changelog + probably should bump major version?

@mensfeld
Copy link
Copy Markdown
Contributor

@stevenou support for ruby 2.1 has ended quite while ago: https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/ - not quite sure if it is that much of a breaking change in that case as this ruby versions shouldn't be used at all...

@nijikon
Copy link
Copy Markdown
Contributor Author

nijikon commented Mar 15, 2018

@stevenou And just to add to what @mensfeld wrote, support for 2.2 will end at the end of March 2018. We will be dropping support for it since the beginning of April. https://www.ruby-lang.org/en/news/2017/12/14/ruby-2-2-9-released/

@stevenou
Copy link
Copy Markdown

i understand that. i'm arguing this is a breaking change and should be noted as such. though i now see there is huge amounts of debate about whether a dependency change should constitute a major version bump or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants