drop auto-detection of ruby framework - go with the manual setup#31
Merged
drop auto-detection of ruby framework - go with the manual setup#31
Conversation
nijikon
suggested changes
Jul 18, 2017
Contributor
nijikon
left a comment
nijikon
left a comment
There was a problem hiding this comment.
Please create CHANGELOG.md and start adding comments there. This is a big change and we need to make our users aware.
Contributor
Author
|
we can add it to release note draft after merge and publish there. will that be enough ? |
Contributor
Author
Contributor
|
When #36 is merged, please add a proper changelog message for this PR. |
Contributor
Author
|
@nijikon done |
bartes
force-pushed
the
auto_detection
branch
2 times, most recently
from
a11d1eb to
26beeba
Compare
nijikon
approved these changes
Jul 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.