add possibility to set do not track in constructor options#42
Merged
Conversation
brissmyr
reviewed
Jul 24, 2017
lib/castle/client.rb
Outdated
| end | ||
|
|
||
| def do_not_track! | ||
| def turn_off_tracking |
Member
There was a problem hiding this comment.
I'd prefer enable and disable vs turn_on and turn_off
bartes
force-pushed
the
dont_track_options
branch
from
7f90c8c to
c6c96c5
Compare
bartes
force-pushed
the
dont_track_options
branch
5 times, most recently
from
c410fb9 to
4f5118d
Compare
bartes
force-pushed
the
dont_track_options
branch
from
4f5118d to
c484d39
Compare
nijikon
approved these changes
Jul 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can pass additional options hash as arguments where do_not_track flag, cookies and context can be passed.
Renamed track! because it was a bit confusing. We use track method for something different.