Conversation
lluft
reviewed
Jul 27, 2017
lib/castle/fake_auth_response.rb
Outdated
|
|
||
| module Castle | ||
| # generate fake authentication response | ||
| class FakeAuthResponse |
Contributor
There was a problem hiding this comment.
@bartes I'd prefer calling this FailoverAuthRespsonse
Contributor
Author
|
TODO: added readme and changelog information |
lluft
reviewed
Jul 31, 2017
Contributor
lluft
left a comment
lluft
left a comment
There was a problem hiding this comment.
Once the error message is changed it's ready to merge
lib/castle/configuration.rb
Outdated
|
|
||
| def failover_strategy=(value) | ||
| @failover_strategy = FAILOVER_STRATEGIES.detect { |strategy| strategy == value.to_sym } | ||
| raise Castle::ConfigurationError, 'there is no such a strategy' if @failover_strategy.nil? |
Contributor
There was a problem hiding this comment.
change the error message to unrecognized failover strategy.
Contributor
Author
lluft
approved these changes
Jul 31, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.