Skip to content

Conversation

@franssl
Copy link
Member

@franssl franssl commented May 11, 2020

  • Skip tests which fail intermittently.

New Pull Request Submissions:

  1. Have you followed the guidelines in our Contributing document?
  2. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  3. I have added tests to cover my changes.
  4. All new and existing tests passed.
  5. Have you lint your code locally prior to submission?
  6. Does your code follows the code style of this project?
  7. Does your change require a change to the documentation.
    • I have updated the documentation accordingly.
  8. Have you added an explanation of what your changes do and why you'd like us to include them?
  9. Have you inserted a keyword and link to the issues the PR closes in its descriptions (ex closes #1) ?
  10. Is you branch up to date, have you integrated all the latest changes from develop and resolved conflicts ?
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

* Skip tests which fail intermittently.
@franssl franssl changed the title Skip tests which fail intermittently. (#1242) Skip tests which fail intermittently May 11, 2020
@franssl franssl added the Pull Request 🕵️ Used for pull requests. label May 11, 2020
@franssl franssl self-assigned this May 11, 2020
@franssl franssl linked an issue May 11, 2020 that may be closed by this pull request
@franssl franssl marked this pull request as ready for review May 12, 2020 08:08
@franssl franssl merged commit 50cb466 into develop May 12, 2020
@franssl franssl deleted the 1240-skip-failing-tests-develop branch May 12, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pull Request 🕵️ Used for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip failing tests

3 participants