Skip to content

Conversation

@Xela101
Copy link

@Xela101 Xela101 commented May 14, 2020

New Pull Request Submissions:

  1. Have you followed the guidelines in our Contributing document?
  2. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  3. I have added tests to cover my changes.
  4. All new and existing tests passed.
  5. Have you lint your code locally prior to submission?
  6. Does your code follows the code style of this project?
  7. Does your change require a change to the documentation.
    • I have updated the documentation accordingly.
  8. Have you added an explanation of what your changes do and why you'd like us to include them?
  9. Have you inserted a keyword and link to the issues the PR closes in its descriptions (ex closes #1) ?
  10. Is you branch up to date, have you integrated all the latest changes from develop and resolved conflicts ?
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix,
    Feature

  • What is the current behavior?

Nodes use PeerId's while LibP2P uses MultiAddress's, because we are integrating LibP2P within Catalyst there is no point in needing to maintain both. However.. we could use a more compressed format of MultiAddress over protobuf messages and reconstruct to a multi-address for a smaller message payload. #1270

From discussions at the start of the year our RPC library is being deprecated in favor of using the Etherium Api endpoints and DFS api. What should we do with the current RPC projects. #1271

MessageDto is used heavily by dotnetty, this can probably be remove now as well as the channel context in observers. #1272

New LibP2P handlers should be added via AutoFac DI. #1273

Use the plain generic IPeerClient, IPeerService libraries for generic services instead of the one specific for libp2p.

@Xela101 Xela101 added the Pull Request 🕵️ Used for pull requests. label Jun 3, 2020
@Xela101 Xela101 self-assigned this Jun 3, 2020
@Xela101 Xela101 marked this pull request as ready for review June 3, 2020 09:03
@Xela101 Xela101 added this to the Full Consensus Sprint 4 milestone Jun 3, 2020
sudhirtibrewal
sudhirtibrewal previously approved these changes Jun 3, 2020
Copy link
Contributor

@sudhirtibrewal sudhirtibrewal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok. need through testing

franssl
franssl previously approved these changes Jun 10, 2020
Copy link
Member

@franssl franssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@sudhirtibrewal sudhirtibrewal merged commit fe7bfdd into develop Jun 16, 2020
@sudhirtibrewal sudhirtibrewal deleted the use-libp2p-in-catalyst branch June 16, 2020 11:24
@Xela101 Xela101 restored the use-libp2p-in-catalyst branch June 16, 2020 13:33
@Xela101 Xela101 deleted the use-libp2p-in-catalyst branch June 16, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Pull Request 🕵️ Used for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants