-
Notifications
You must be signed in to change notification settings - Fork 9
Modularization of network layer #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
315c962 to
64d6bcb
Compare
sudhirtibrewal
previously approved these changes
Jul 21, 2020
franssl
previously approved these changes
Jul 21, 2020
Member
franssl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, much better with the network modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Submissions:
closes #1) ?What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Enhancement
What is the current behavior? (You can also link to an open issue here)
Dotnetty and LibP2P scattered in the Core.Lib libraries.
What is the new behavior (if this is a feature change)?
Dotnetty and LibP2P network classes have been separated into their own autofac modules.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: