Skip to content

Conversation

@Xela101
Copy link

@Xela101 Xela101 commented Jul 14, 2020

New Pull Request Submissions:

  1. Have you followed the guidelines in our Contributing document?
  2. Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  3. I have added tests to cover my changes.
  4. All new and existing tests passed.
  5. Have you lint your code locally prior to submission?
  6. Does your code follows the code style of this project?
  7. Does your change require a change to the documentation.
    • I have updated the documentation accordingly.
  8. Have you added an explanation of what your changes do and why you'd like us to include them?
  9. Have you inserted a keyword and link to the issues the PR closes in its descriptions (ex closes #1) ?
  10. Is you branch up to date, have you integrated all the latest changes from develop and resolved conflicts ?
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Enhancement

  • What is the current behavior? (You can also link to an open issue here)
    Dotnetty and LibP2P scattered in the Core.Lib libraries.

  • What is the new behavior (if this is a feature change)?
    Dotnetty and LibP2P network classes have been separated into their own autofac modules.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

@Xela101 Xela101 changed the base branch from master to develop July 14, 2020 09:58
@Xela101 Xela101 marked this pull request as ready for review July 16, 2020 09:05
@Xela101 Xela101 self-assigned this Jul 17, 2020
@Xela101 Xela101 added Enhancement 👷 New feature or request Pull Request 🕵️ Used for pull requests. labels Jul 17, 2020
@Xela101 Xela101 added this to the Full Consensus Sprint 7 milestone Jul 17, 2020
@Xela101 Xela101 force-pushed the modularize-network-layer branch from 315c962 to 64d6bcb Compare July 20, 2020 09:36
sudhirtibrewal
sudhirtibrewal previously approved these changes Jul 21, 2020
franssl
franssl previously approved these changes Jul 21, 2020
Copy link
Member

@franssl franssl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, much better with the network modules

@Xela101 Xela101 closed this Jul 22, 2020
@Xela101 Xela101 reopened this Jul 22, 2020
@sudhirtibrewal sudhirtibrewal merged commit 290a2ae into develop Jul 22, 2020
@sudhirtibrewal sudhirtibrewal deleted the modularize-network-layer branch July 22, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement 👷 New feature or request Pull Request 🕵️ Used for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants