Switch to using composer and patches to manage simplesamlphp depedency#878
Merged
brendanheywood merged 8 commits intoMOODLE_405_STABLEfrom Mar 31, 2025
Merged
Switch to using composer and patches to manage simplesamlphp depedency#878brendanheywood merged 8 commits intoMOODLE_405_STABLEfrom
brendanheywood merged 8 commits intoMOODLE_405_STABLEfrom
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working for me. Unsure about the test fails, seams like every PR is failing tests, so don't think it is set up properly for it?
Do NOT click on files changed tab, it just crashes my entire laptop.
Why?
Current method involves deleting simplesaml2, downloading a new copy, cleaning it up. Finding our customisations, cherry-picking them etc, its a lengthy and error-prone process. With this change we can just run
composer updateand let it update.Moodle itself is also moving towards composer native support in 5.1. Once that is out I am hoping our 5.1 branch can just stop committing our
vendorfolder and have it work with the Moodle vendor system, but that is still TBCWe also now have a
patches/folder with all our customisation's, making it obvious what changes we have made.Changes
.extlibwith our customised version ofsimplesamlphpcomposer.jsonto requiresimplesamlphpvendorfolder, so composer is not required for usage, still just installs and works same as with.extlibfoldersimplesamlphpDockerfileanddocker-compose.yamlNOT for production usage, but as a way to run composer in a standard, repeatable way