Update rental/lr #32
Merged
Update rental/lr #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd the movie_title in the request body
Owner
There was a problem hiding this comment.
Wait -- so does the '/2' refer to the customer ID or the rental ID?
Owner
|
If rental id should not be used, should this instead be on the customer controller? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to change the rental model function checkIn to also use the customer_id so it didn't add the return date to all rentals with that movie_title. This does not handle the edge case of a single customer checking out more than one copy of a movie but the requirements say to use the customer id and the movie title rather than the rental id to check in a movie. I updated the model and controller tests to reflect this change.