feat(google-contacts): init #1649
Conversation
Co-authored-by: uncenter <uncenter@uncenter.dev>
|
I'll merge in the requested changes regarding the RGB variables and the hardcoded colours in a bit: then we can move onto resolving the accent container colours. |
uncenter
added
the
2.status: changes-requested
uncenter
removed
the
2.status: changes-requested
|
I'll try to test this on various Google Workspace plans later today to see if there's any CSS differences that need to be corrected. |
|
There's some things that aren't themed on higher Google Workspace plans like delegates and the name plate: I'll fix those up then you can review. Could you also look into the Latte style rules not working: I still haven't figured it out and left a comment in the file for you to look at. |
|
Oops: I meant to merge my latest commits first, please wait a few minutes |
|
That should be good. |
|
@uncenter Ready for review! |
|
I noticed that GitHub says that there's requested changes that need to be resolved: however, I'm not actually sure what needs to be changed. Could that be pointed out? |
|
There are no changes requested at the moment, I have not re-reviewed. Until then though please see to the linter errors. |
|
Never mind, the linter is throwing a fit that I'll see to later. Ignore for now. |
|
Noticed the checkbox for |
|
Nope, that appears to have been a misclick. |
|
It was mentioned how the generated class names with no comments can be hard to maintain so I added descriptions of what most classes target. |
uncenter
added
the
2.status: pending
uncenter
removed
the
2.status: pending
|
Considering how this app and Google Cloud use the --gm variables quite heavily in legacy areas, might want to consider making a library for them at some point. |
| google-contacts: | ||
| name: Google Contacts | ||
| link: https://contacts.google.com | ||
| categories: [social_networking] |
There was a problem hiding this comment.
Not really social networking, now that I think about it...
|
|
||
| // Ink ripple | ||
| .z80M1.qs41qe>.aBBjbd { | ||
| background-image: radial-gradient(closest-side, rgba(var(--gm3-sys-color-on-surface-rgb), 0.16) max(100% - 70px, 65%), rgba(var(--gm3-sys-color-on-surface-rgb), 0) 100%); |
There was a problem hiding this comment.
Not sure this should be the soft ripple variant on legacy components.
| border-right-color: transparent; | ||
| } | ||
|
|
||
| // Loader chromeAPI page progress bar |
There was a problem hiding this comment.
Specifically themes the BOQ page progress bar.
uncenter
added
5.needs: staff-review
WalkQuackBack
added
the
4.topic: libraries
4 participants
🎉 Theme for Website 🎉
Google Contacts is a contact management application for G Suite, also known as Google Workspace.
💬 Additional Comments 💬
I struggle with differentiating certain colours, so I may have left certain colour combos that are not very legible together. When reviewing please point them out to me and I will try my best to fix them.
🗒 Checklist 🗒
/styles/<name-of-website>containing the contents of the/templatedirectory.userstyles.ymlfile with information about the new userstyle.catppuccin.user.less- all the CSS for the userstyle, based on the template.preview.webp- composite image of all four individual flavor screenshots (taken with the default accent color of mauve) stitched together, generated via Catwalk.