How to include additional headers?

[tomasguisasola]

In my application I need to call a service that requires a "Bearer" header. I added it after the call to mp.gen_request(), but I think the length of the header (now with more info) would be incorrect thus, the final content-length would be also incorrect. What do you think of adding an entry in gen_request's parameter to provide "additional_headers" or something like that?

[catwell]

Adding it after mp.gen_request() like below should be fine, the request headers are not part of the content length.

local rq = mp.gen_request(...)
rq.headers.authorization = "Bearer mytoken123"

Have you tried this and gotten an error? If so can you give more details? If possible try to reproduce the issue using httpbin.org like the tests do.

[tomasguisasola]

I did exactly what you suggested and the request worked with success. But since the code explicit calculates the headers_length, I thought it would be better to consider that. If that's all, then I suggest you to mention that in the example.

Anyway, thanks for the piece of software.

[catwell]

I understand the confusion, the "headers" it's talking about are not the request headers. In the multipart format each part has headers, and they are encoded inside the body. That's the headers whose length it calculates, so it is unchanged by adding headers to the request.

I agree that I could add that to the example and/or tests, I'll do it when I find a little time!

[tomasguisasola]

Great! Thanks!