the boundary contains " sometimes have bug#7
Merged
Conversation
Owner
|
The boundary cannot contain a quote character (see the code of Do you mean there is a bug in another piece of software (a Web server)? Can you give more details on the bug? |
Contributor
Author
|
Say RFC2046 allow boundry have quote, but not must .So some webserver doer not support this |
Owner
|
OK, I understand the problem. This does not introduce a bug because the boundary here is always generated by gen_boundary and hence composed of letters and dashes, which are not separators in HTTP headers, so it is a token. Given that I see no reason not to merge. Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the boundary contains " sometimes have bug