Skip to content

chore(adapter): make subprocess shell mode explicit#66

Merged
caverav merged 1 commit intomainfrom
chore/explicit-shell-false
Mar 29, 2026
Merged

chore(adapter): make subprocess shell mode explicit#66
caverav merged 1 commit intomainfrom
chore/explicit-shell-false

Conversation

@caverav
Copy link
Copy Markdown
Owner

@caverav caverav commented Mar 29, 2026

Summary

  • make the blutter subprocess invocation explicitly non-shell
  • improve clarity for code review and static analysis

Testing

  • not run (no behavior change)

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4c3b0537-83c0-46d1-ada6-87ffde6b6a78

📥 Commits

Reviewing files that changed from the base of the PR and between 1d9c7d1 and 8342446.

📒 Files selected for processing (1)
  • adapters/python/adapter_template.py

Walkthrough

The _run_blutter_dump function in adapters/python/adapter_template.py was updated to explicitly set shell=False when calling subprocess.run. Previously, the code relied on the default behavior of the subprocess module without specifying this parameter. The command execution, stdout/stderr capture, and text mode handling remain unchanged.

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The description provides a summary of the change but does not follow the required template structure with validation checklist and scope sections. Add the required template sections including validation checklist (cargo fmt, clippy, test), scope verification, and documentation updates confirmation.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: making subprocess shell mode explicit in the adapter code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@caverav caverav merged commit 2574d2a into main Mar 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant