Deploy assets for reverse proxy#5
Merged
Merged
Conversation
|
Preview deployment ready
|
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on January 9
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
…existing Cloudflare Pages projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the deployment workflow and build configuration to support both root and subpath deployments of the
@cazala/playgroundapp, enabling it to be served at bothparty.caza.laand as a subpath atcaza.la/party. The changes ensure proper asset routing, type checking, and deployment to separate Cloudflare Pages projects for each deployment target.Deployment workflow enhancements:
.github/workflows/deploy.ymlnow performs a type check and creates two separate builds of the@cazala/playgroundapp: one for the root path and one for the/party/subpath, with the subpath build outputting todist-party-assets.party-assets, to host the subpath build used for reverse proxying atcaza.la/party.dist-party-assets) is deployed to the newparty-assetsproject in addition to the standard deployment.Build and routing configuration:
packages/playground/vite.config.jsnow dynamically sets thebaseoption based on theVITE_PUBLIC_BASEenvironment variable, normalizing it to ensure correct asset paths for both root and subpath deployments._redirectsfile inpackages/playground/publicensures that all routes are redirected toindex.htmlfor proper SPA routing.Note
Enables dual deployment of the playground for both root and subpath hosting, plus guidance for an edge reverse-proxy.
@cazala/playgroundtwice (root and subpath viaVITE_PUBLIC_BASE=/party/), add type-check step, safer project existence checks, and deploy bothdist→partyanddist-party-assets→party-assets; include--commit-dirty=truefor preview/production.basenow derived fromVITE_PUBLIC_BASEwith normalization to ensure correct asset paths under/party/._redirectsfor SPA fallback (/* /index.html 200).docs/edge-repo-llm-instructions-caza-la-party-worker.mddescribing a Cloudflare Worker that reverse-proxiescaza.la/partytohttps://party-assets.caza.la.Written by Cursor Bugbot for commit 12b52ef. This will update automatically on new commits. Configure here.