Merged
Conversation
cb341
commented
Jan 25, 2025
| Update, | ||
| ( | ||
| player_systems::handle_controller_movement_system, | ||
| player_systems::handle_player_collider_events_system, |
Owner
Author
There was a problem hiding this comment.
Seems contraversial at first:
Q: Why would you want to run the controller movement systems when the player is chatting?
A: What if the player jumped into the air and while in air opened up the chat? Without these systems, the player would fall through the ground.
cb341
commented
Jan 25, 2025
| mut next_state: ResMut<NextState<GameState>>, | ||
| key_input: Res<ButtonInput<KeyCode>>, | ||
| ) { | ||
| if key_input.just_pressed(KeyCode::Tab) { |
Owner
Author
There was a problem hiding this comment.
I love how clean the state transitions are here 😍
cb341
commented
Jan 25, 2025
| chat_input_query.get_single_mut(), | ||
| ) { | ||
| info!("Handling unfocus state"); | ||
| container_classes.remove_class("focused"); |
Owner
Author
There was a problem hiding this comment.
I am still unhappy with the classes, but what can I do 🤷♂️
cb341
commented
Jan 25, 2025
cb341
changed the title
cb341
commented
Jan 25, 2025
|
|
||
| #chat_message_input { | ||
| margin: 0px; | ||
| margin-top: 15px; |
Owner
Author
There was a problem hiding this comment.
Unrelated change, but might aswell fix the margin..
cb341
commented
Jan 25, 2025
| ) { | ||
| let mut window = window_query.single_mut(); | ||
| if btn.just_pressed(MouseButton::Left) { | ||
| if btn.just_pressed(MouseButton::Left) && *current_state.get() != GameState::Debugging { |
Owner
Author
There was a problem hiding this comment.
Could check for playing and chatting instead...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the egui crate and the inspector crate, the entire state needs to be reworked because technical debt and problems:
I am so relieved that the chat system is no longer sketchy but looks like a genuinely robust solution with the state transitions 😄
New States