Fix bugeous crtime value on macOS#322
Merged
cberner merged 1 commit intocberner:masterfrom Nov 27, 2024
Merged
Conversation
FirelightFlagboy
force-pushed
the
fix-crtime-overflow
branch
from
2539670 to
d4dd675
Compare
During certain operation, macOS use some helper that send request to the mountpoint with `crtime` set to `0xffff83da4f80`. That value correspond to `-2_082_844_800u64` which is the difference between the date 1904-01-01 and 1970-01-01 because macOS epoch start at 1904 and not 1970. <macfuse/macfuse#1042> Fix cberner#217
cberner
force-pushed
the
fix-crtime-overflow
branch
from
d4dd675 to
767b925
Compare
Owner
|
Thanks for digging in and figuring out the root cause here! |
cberner
approved these changes
Nov 27, 2024
|
Awesome! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During certain operation, macOS use some helper that send request to the mountpoint with
crtimeset to0xffff83da4f80. That value correspond to-2_082_844_800u64which is the difference between the date 1904-01-01 and 1970-01-01 because macOS epoch start at 1904 and not 1970.macfuse/macfuse#1042
Fix #217