Return error from umount rather than just logging#578
Merged
cberner merged 1 commit intocberner:masterfrom Jan 27, 2026
Merged
Conversation
stepancheg
requested a deployment
to
macstadium
GitHub Actions
Waiting
stepancheg
force-pushed
the
umount-error
branch
from
093268c to
bf893a6
Compare
stepancheg
requested a deployment
to
macstadium
GitHub Actions
Waiting
stepancheg
force-pushed
the
umount-error
branch
from
bf893a6 to
8b56df0
Compare
stepancheg
requested a deployment
to
macstadium
GitHub Actions
Waiting
Also rename umount implementations `Mount` -> `MountImpl`.
stepancheg
force-pushed
the
umount-error
branch
from
8b56df0 to
01e1a35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also rename umount implementations
Mount->MountImpl.