Allow empty string as part of main parameter #306 #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
One test failed, can you take a look? |
…ned put main parameter given
…nto issue-306-empty-string-as-parameter * 'master' of https://github.com/jeremysolarz/jcommander: Add changelog entry for cbeust#305 Do not display default value for help parameter in usage Finalize test case for omitting of default value display in usage output # Conflicts: # CHANGELOG.md # src/main/java/com/beust/jcommander/JCommander.java
Contributor
Author
|
Fixed the test according to my comment in #306. I commented on the failing test. Is my understanding in my last comment there correct? Best, JS |
Owner
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Main parameter
is defined and the program is called with an empty string as a parameter
java -jar jcommander-program.jar param1 ""with the current implementation the parameter is removed.
The PR changes this.
@cbeust I am not sure why the empty string test was there in the beginning.
If there was a reason please tell and I will amend this PR accordingly.