fix: exclude skill JS files from Biome linting#67
Conversation
Claude Code skill .js files are evaluated as function bodies, so top-level return statements are valid. Biome parses them as standalone modules and flags the return as a syntax error, causing false positives in CodeRabbit reviews. Assisted-by: Claude:claude-opus-4-6
|
Warning Review limit reached
Next review available in: 41 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds a root-level biome.jsonc to exclude Claude Code skill JavaScript files (**/skills/**/*.js) from Biome analysis. The goal is to suppress a CodeRabbit/Biome false positive ("Illegal return statement outside of a function") on pr-review-toolkit/skills/review-pr/review-pr.js, which is a Claude Workflow script (evaluated as a function body where top-level return is valid) rather than a standalone module. This mirrors existing exclusion patterns already used for skill content in .skillsaw.yaml, .markdownlint-cli2.jsonc, and .coderabbit.yaml, though with a broader glob.
Changes:
- Adds a new
biome.jsoncat the repository root pinned to the Biome 2.0.6 schema. - Configures an exclusion so skill
.jsfiles are not linted by Biome.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "ignore": [ | ||
| "**/skills/**/*.js" | ||
| ] |
Summary
biome.jsoncto exclude**/skills/**/*.jsfrom Biome analysispr-review-toolkit/skills/review-pr/review-pr.js.jsfiles are evaluated as function bodies where top-levelreturnis valid, but Biome parses them as standalone modulesTest plan
biome.jsoncis valid JSON