feat(pbes1): add OID mappings for PBES1 combinations#389
Open
Ayush-Patel-56 wants to merge 1 commit intocbomkit:mainfrom
Open
feat(pbes1): add OID mappings for PBES1 combinations#389Ayush-Patel-56 wants to merge 1 commit intocbomkit:mainfrom
Ayush-Patel-56 wants to merge 1 commit intocbomkit:mainfrom
Conversation
Signed-off-by: Ayush Patel <ayushpatel2731@gmail.com>
Ayush-Patel-56
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added OID resolution for PBES1 algorithm combinations during the enrichment phase. This ensures CBOM output includes correct OIDs for both PKCS#5 and PKCS#12 variants, which were previously missing.
Changes
PBES1Enricherto map digest/cipher combinations to their respective OIDs (RFC 2898 and PKCS#12).Enricherpipeline.PBES1.java.PBES1EnricherTestwith coverage for PKCS#5 and PKCS#12 scenarios.Related Issues
Fixes #384
Verification
mvn test -pl enricher -Dtest=PBES1EnricherTest.Screenshots
Attached is a screenshot showing the node tree before and after enrichment, confirming the OID is correctly resolved:
