Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reorganizes the build and test workflow to better centralize test orchestration in the Makefile. The build target now runs unit tests before compiling (with a new binary target for compile-only work), and a dedicated test-ci target consolidates the CI test suite definition in one place instead of having it split between the Makefile and CI workflow.
Changes:
- Refactored
buildtarget to run unit tests before compilation, withbinarytarget for compile-only operations - Added
test-citarget that orchestrates the complete CI test suite viatest-all - Updated CI workflow to delegate all test orchestration to
make test-ci
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Split build into test+binary, added test-ci target, updated dependencies for test-cli/test-cli-live to use binary |
| .github/workflows/ci.yml | Consolidated separate unit and CLI test steps into single test-ci invocation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildnow runs unit tests before compiling by splitting compile-only work into a newbinarytargettest-citarget that runs the deterministic CI suite viatest-allmake test-ciso test orchestration is defined in one placeTesting