Updated the sed command

[joncard1]

Without the "-i" switch, the underlying file is not affected, and the "$" introduced a typo in the C file.

[joncard1]

I tested this on my Pico in version 1.22, 1.23, and 1.24, with some complicated results. My test application doesn't simplify well; it creates an access point, advertises a service over mDNS, then starts a simple HTTP server. In version 1.22 and 1.23, I was able to connect my Windows 11 desktop to the AP and open a web browser to the hostname of the Pico and it retrieved the page. In 1.24, I was able to run the application with getting an error, but the desktop was not able to connect at the name, but was able to connect to web server at the IP address. However, I was able to verify port 5353 was open, but I'm not knowledgeable enough about mDNS to actually see why the Windows desktop wasn't able to resolve the name. I can keep looking, but please let me know if you have a better way of confirming the behavior of a Pico running this library on Micropython 1.24.

[cbrand]

Hey thank you for the patch and testing.

I do by now have a raspberry pi pico and try 1.24 out with your patch to see if I run in the same problem.
What you could do is to see on Wireshark on your windows device the mdns packets by filtering for port 5353 and could see if the pico at all sends any mdns data or not.

[cbrand]

After playing a bit around with 1.24 it seems like something in the network stack changed.

Binding to a socket without an IP address does no longer work / allow to send packages to the network respectively.

After updating the bind parameters it does work with 1.24 but not on an ESP32 before 1.22.

Realistically nobody needs any build without the newest version though, so I am doing a release an dropping support for everything before 1.24 and not adding a backwards compatibility check / hack into the codebase.