sameold,samedec: round purge times to 15 or 30 minutes #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix erroneous documentation on `MessageHeader::is_expired_at()`. * The maximum duration of SAME messages is 99.5 hours [1]… * … And we only need to be within ±90 days anyway. [1]: https://www.weather.gov/nwr/samealertduration
Previous versions of sameplace erroneously stated that the
expiration time of a SAME message was
issue datetime + purge duration
This is *almost* correct, but there's a catch:
* the expiration time is rounded to the nearest 15 minute
increment for durations ≤1 hour
* the expiration time is rounded to the nearest 30 minute
increment for longer-duration messages
Add `MessageHeader::purge_datetime()` to calculate this time, and
fix the incorrect `Message::is_expired_at()` implementation to
match. Documentation is given a touch-up.
Source the purge time from `MessageHeader::purge_datetime()` instead of calculating it directly. The rounding behavior will change the output.
cbs228
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of sameplace erroneously stated that the expiration time of a SAME message was
This is almost correct, but there's a catch:
the expiration time is rounded to the nearest 15 minute increment for durations ≤1 hour
the expiration time is rounded to the nearest 30 minute increment for longer-duration messages
the maximum duration of a SAME message is 99.5 hours 1
Add
MessageHeader::purge_datetime()to calculate this time, and fix the incorrectMessage::is_expired_at()implementation to match. Documentation is given a touch-up.This is an API-expanding change for sameold and will change samedec's
SAMEDEC_PURGETIMEvalues.