Skip to content

Assess and port exec-server filesystem helper lifecycle hardening #215

@shiny-code-bot

Description

@shiny-code-bot

Current Status

State: Completed - non-applicable to editable Every Code code-rs.
Next action: None.
Blocked by: None.
Waiting for: Future exec-server/fs-helper import work, if Every Code later adopts that architecture.
Last verified: 2026-05-30.

Evidence: OpenAI commits 451b386 and a717e4e modify codex-rs/exec-server/src/fs_sandbox.rs, adding kill_on_drop(true) to the dedicated sandbox filesystem helper child and preserving macOS __CF_USER_TEXT_ENCODING in that helper's narrow allowlist. Editable code-rs has no exec-server crate, FileSystemSandboxRunner, CODEX_FS_HELPER_ARG1 / --codex-run-as-fs-helper dispatch, fs_sandbox module, or fs/readFile/fs/writeFile app-server handlers. Existing code-rs spawn paths already use kill_on_drop(true) for generic command/agent/MCP child processes, and MCP/RMCP env allowlists already preserve __CF_USER_TEXT_ENCODING.

Validation: ./build-fast.sh passed from /Users/cbusillo/Developer/code-exec-fs-helper-lifecycle on 2026-05-30.

Finish Line

Every Code either ports the applicable filesystem-helper lifecycle hardening or records why the OpenAI exec-server helper path does not apply.

Acceptance Criteria

  • Inspect OpenAI commits 451b386442 and a717e4ef31 and identify whether code-rs has an equivalent helper-spawn path.
  • If applicable, ensure helper child processes are killed when their owning handle is dropped or cancelled.
  • If applicable on macOS, preserve __CF_USER_TEXT_ENCODING in the narrow helper environment allowlist.
  • Add focused regression coverage or a documented non-applicability note.
  • Validate with ./build-fast.sh.

Notes

The upstream patch is intentionally small, but Every Code may not have a one-to-one editable exec-server crate. Treat this as a lifecycle audit first and a port second.

Metadata

Metadata

Assignees

No one assigned

    Labels

    planDurable planning issueplan:donePlan completed or superseded

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions