feat(core): add skill command policies#237
Merged
Merged
Conversation
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #236
Blocked by nothing. Follow-up migration issue: #235.
Summary
policy.command_policiesto skill frontmatter so skills can own raw command patterns without hardcoding tools likeghin Every Code.gh pr mergebeforeExecCommandBegin.Schema Shape
Supported v1 matchers are
argv_exact,argv_prefix, andshell_regex; each policy must declare exactly one. Supported v1 actions arerequire_preferred,require_confirm, andreject. Passive warn-and-run behavior is intentionally left out until there is a real continue-and-run execution path.Validation
cargo test -p code-core command_policy --libcargo test -p code-core --test skill_command_policycargo test -p code-core selected_skill_messages_include_explicit_dollar_skill_once --libgit diff --check./build-fast.sh