Add exec harness safety scenarios#408
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- add fake-response exec harness coverage for shell command round-trip behavior\n- add fake-response read-only sandbox write-denial coverage\n- extend harness expectations for command events, grouped event-count alternatives, and function-call output assertions\n- include both new scenarios in the deterministic harness smoke gate\n\nFixes #407\n\n## Validation\n- python3 -m py_compile tools/code-exec-harness/harness.py\n- python3 -m json.tool tools/code-exec-harness/scenarios/exec-shell-command-roundtrip.json\n- python3 -m json.tool tools/code-exec-harness/scenarios/exec-readonly-write-denied.json\n- git diff --check\n- python3 tools/code-exec-harness/harness.py tools/code-exec-harness/scenarios/exec-shell-command-roundtrip.json tools/code-exec-harness/scenarios/exec-readonly-write-denied.json --code-bin /Users/cbusillo/Developer/code/code-rs/target/release/code\n\n## Local Build Note\n- ./build-fast.sh was attempted twice but did not reach compilation locally because Cargo metadata stalled fetching the realtime-webrtc git dependency submodule livekit/protocol from https://github.com/juberti-oai/rust-sdks.git. An offline metadata probe confirms the missing dependency fetch path. CI should be the source of truth if its network/cache can fetch that dependency.