Add local code rebuild preflight check#413
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/local/rebuild-path-code.sh --preflight/--dry-runto inspect PATH and release-bin wiring without building or mutating filesjust local-code-rebuild-preflightand a deterministic temp-fixturejust local-code-rebuild-preflight-checkPATH code --versionafter rebuild when PATH does not resolve to the rebuilt binaryRefs #412.
Validation
just local-code-rebuild-preflight-checkbash -n scripts/local/rebuild-path-code.sh scripts/local/check-code-rebuild-preflight.shgit diff --check --cached./build-fast.shjust harness-smokeReview
A scoped read-only agent review found one blocking issue: after a successful rebuild with mismatched PATH, the script still ran
path_code --version, which could verify an unrelated binary. This PR now gates that call on safe PATH wiring and prints a skip note otherwise. The review's low-friction suggestions were also handled: portablels -l, documented--dry-run, and a missing-PATH fixture.